On Tue, May 30, 2017 at 02:50:54PM +0200, Simon Horman wrote: > Trivial updates to improve checkpatch cleanness. > > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> Two comments here: > - /* Orginally registers were 16 bit apart, could be 32 or 64 nowadays */ > - if (!host->bus_shift && resource_size(res) > 0x100) /* old way to determine the shift */ > + /* > + * Originally registers were 16 bit apart, could be 32 or 64 nowadays. > + * Old way to determine the shift: > + */ > + if (!host->bus_shift && resource_size(res) > 0x100) > host->bus_shift = 1; I liked the old way much better because it makes clearer which comment belongs to the whole block and which comment belongs to just this one line. > /* > - * All SDHI have CMD12 controll bit > + * All SDHI have CMD12 control bit > */ Single line comment? And hooray for finally fixing the controll bit :D
Attachment:
signature.asc
Description: PGP signature
