On Tue, Apr 25, 2017 at 4:22 PM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>
> On 25/04/17 13:50, Shubhrajyoti Datta wrote:
> > Hi Adrian,
> >
> > Thanks for the review.
> >
> > On Tue, Apr 25, 2017 at 3:47 PM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
> >>
> >> On 20/04/17 08:44, Shubhrajyoti Datta wrote:
> >>> Currently the clock are enabled at probe and released at driver
> >>> removal. This moves to enable before mmc read/ write and disables
> >>> after it.
> >>>
> >>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> >>> ---
> >>> drivers/mmc/host/sdhci-of-arasan.c | 50 ++++++++++++++++++++++++++++++++++++--
> >>> 1 file changed, 48 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> >>> index 1cfd7f9..812e75a 100644
> >>> --- a/drivers/mmc/host/sdhci-of-arasan.c
> >>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> >>> @@ -24,6 +24,7 @@
> >>> #include <linux/module.h>
> >>> #include <linux/of_device.h>
> >>> #include <linux/phy/phy.h>
> >>> +#include <linux/pm_runtime.h>
> >>> #include <linux/regmap.h>
> >>> #include "sdhci-pltfm.h"
> >>> #include <linux/of.h>
> >>> @@ -373,10 +374,44 @@ static int sdhci_arasan_resume(struct device *dev)
> >>>
> >>> return sdhci_resume_host(host);
> >>> }
> >>> +
> >>
> >> Runtime PM is under CONFIG_PM not CONFIG_PM_SLEEP
> >
> > Will fix.
> >
> >>
> >>> +static int sdhci_arasan_runtime_suspend(struct device *dev)
> >>> +{
> >>> + struct platform_device *pdev = to_platform_device(dev);
> >>> + struct sdhci_host *host = platform_get_drvdata(pdev);
> >>> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> >>> + struct sdhci_arasan_data *sdhci_arasan = sdhci_pltfm_priv(pltfm_host);
> >>> + int ret;
> >>> +
> >>> + ret = sdhci_runtime_suspend_host(host);
> >>
> >> Other drivers now have:
> > Can you point me to an example.
> >
> >>
> >> if (host->tuning_mode != SDHCI_TUNING_MODE_3)
> >> mmc_retune_needed(host->mmc);
> >>
> >> If you don't need re-tuning, maybe add a comment so we know.
> >
> > I didnt I understood this one.
> > I am calling sdhci_runtime_suspend_host which has.
> >
> > 2907
> > 2908 int sdhci_runtime_suspend_host(struct sdhci_host *host)
> > 2909 {
> > 2910 unsigned long flags;
> > 2911
> > 2912 mmc_retune_timer_stop(host->mmc);
> > 2913 if (host->tuning_mode != SDHCI_TUNING_MODE_3)
> > 2914 mmc_retune_needed(host->mmc);
> >
> >
> > Am I missing something
>
> It has changed recently, so you need to look at the 'next' branch of Ulf's
> mmc tree:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git
Thanks for the heads up will fix in the next version.
I didnt have the latest updates in my tree.
>
> >>
> >>> +
> >>> + clk_disable_unprepare(pltfm_host->clk);
> >>> + clk_disable_unprepare(sdhci_arasan->clk_ahb);
> >>> +
> >>> + return ret;
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
