On 04/04/17 11:48, Wolfram Sang wrote: > Hi Adrian, > > On Mon, Mar 20, 2017 at 07:50:35PM +0200, Adrian Hunter wrote: >> Make use of an Intel ACPI _DSM that provides eMMC driver strength. >> >> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> > > This is an interesting patch for me because it seems I have to deal with > drive-strength soon, as well, for the SDHI driver. You basically fall > back here to simply read the drive strength value from ACPI, right? Yes, it is a single value. I did not design the _DSM, it was a preexisting method. > So, > do you think it makes sense then to have a similar encoded value from DT > (maybe "mmc-fixed-driver-type-<n>" with n=0..4)? The _DSM, being a device-specific method does not have to support different devices with different requirements whereas DT does. > This is a largely > reduced encoding of what you proposed in 2015 [1] but may be more > pragmatic for soldered on-board devices working on their max speeds with > fixed voltages and frequencies? Or did I get something wrong? What I proposed was being forced on me by the requirement to provide a solution that could meet any conceivable need. That gets over-complicated. But as you say, in practice people are probably only interested in providing one value for the max speed / frequency. > > Thanks, > > Wolfram > > [1] https://lkml.org/lkml/2015/2/16/273 > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
