On 10 April 2017 at 13:11, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > On 10/04/17 14:01, Ulf Hansson wrote: >> On 13 March 2017 at 13:36, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: >>> Add helper functions to enable or disable the Command Queue. >>> >>> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> >>> --- >>> Documentation/mmc/mmc-dev-attrs.txt | 1 + >>> drivers/mmc/core/mmc.c | 2 ++ >>> drivers/mmc/core/mmc_ops.c | 28 ++++++++++++++++++++++++++++ >>> drivers/mmc/core/mmc_ops.h | 2 ++ >>> include/linux/mmc/card.h | 1 + >>> 5 files changed, 34 insertions(+) >>> >>> diff --git a/Documentation/mmc/mmc-dev-attrs.txt b/Documentation/mmc/mmc-dev-attrs.txt >>> index 404a0e9e92b0..dcd1252877fb 100644 >>> --- a/Documentation/mmc/mmc-dev-attrs.txt >>> +++ b/Documentation/mmc/mmc-dev-attrs.txt >>> @@ -30,6 +30,7 @@ All attributes are read-only. >>> rel_sectors Reliable write sector count >>> ocr Operation Conditions Register >>> dsr Driver Stage Register >>> + cmdq_en Command Queue enabled: 1 => enabled, 0 => not enabled >>> >>> Note on Erase Size and Preferred Erase Size: >>> >>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c >>> index 7fd722868875..5727a0842a59 100644 >>> --- a/drivers/mmc/core/mmc.c >>> +++ b/drivers/mmc/core/mmc.c >>> @@ -790,6 +790,7 @@ static int mmc_compare_ext_csds(struct mmc_card *card, unsigned bus_width) >>> MMC_DEV_ATTR(raw_rpmb_size_mult, "%#x\n", card->ext_csd.raw_rpmb_size_mult); >>> MMC_DEV_ATTR(rel_sectors, "%#x\n", card->ext_csd.rel_sectors); >>> MMC_DEV_ATTR(ocr, "%08x\n", card->ocr); >>> +MMC_DEV_ATTR(cmdq_en, "%d\n", card->ext_csd.cmdq_en); >> >> Why do we need to be able to change this from userspace? > > MMC_DEV_ATTR makes it read-only, so it is just a way for userspace to see if > command queue is enabled. Of course! Thanks for the clarification - and yes, that makes sense! Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
