On 23 March 2017 at 01:18, Jin Qian <jinqian@xxxxxxxxxxx> wrote: > Extend sysfs to access ext_csd revision information. > > Signed-off-by: Jin Qian <jinqian@xxxxxxxxxxx> > --- > drivers/mmc/core/mmc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index 7fd722868875..08c62c9bec48 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -779,6 +779,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid); > MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name); > MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid); > MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv); > +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev); We have "product revision" in CID, we have "CSD structure/spec version" in CSD and some other related in EXT_CSD. To make it clear what "rev" is about, I suggest we follow Jaehoon suggestions. Let's name it "ext_csd_rev". > MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info); > MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n", > card->ext_csd.device_life_time_est_typ_a, > @@ -836,6 +837,7 @@ static struct attribute *mmc_std_attrs[] = { > &dev_attr_name.attr, > &dev_attr_oemid.attr, > &dev_attr_prv.attr, > + &dev_attr_rev.attr, > &dev_attr_pre_eol_info.attr, > &dev_attr_life_time.attr, > &dev_attr_serial.attr, > -- > 2.12.1.500.gab5fba24ee-goog > Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html