[...] >>> @@ -166,6 +166,7 @@ int mmc_wait_for_cmd(struct mmc_host *host, struct mmc_command *cmd, >>> int retries); >>> >>> int mmc_hw_reset(struct mmc_host *host); >>> +void mmc_hw_reset_pwrseq(struct mmc_host *host); >> >> Don't you think we can make this transparent to mmc host drivers, >> instead of them having to assign their host_ops->hw_reset() callback >> to this new API? Because I guess that's the though!? >> >> In principle the mmc core already have all the information it needs, >> as to understand when the eMMC pwrseq should be invoked. Or perhaps >> the code may become a bit too messy for that? >> > The easiest way I could think of: > If host->ops->hw_reset is NULL overwrite it with pwrseq->ops->reset > in mmc_add_host. But host->ops is defined es being const, so the compiler > won't allow us to do this. Of course we could do some casting but usually > I try to avoid hacks like casting away const qualifiers. No thanks. :-) [...] Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html