2017-03-03 12:37 GMT+09:00 Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>: > Currently the get_timeout_clock callabck doesn't clearly > have a statment that it needs the variant drivers to return > the timeout clock rate in KHz if the SDHCI_TIMEOUT_CLK_UNIT > isn't present, otherwise the variant drivers should return it > in KHz. So actually sdhci-of-arasan return the wrong value found > by Anssi[1]. It's also very likely that further variant drivers which > are going to use this callback will be confused by this situation. > Given the fact that modem sdhci variant hosts are very prone to get > the timeout clock from common clock framework(actuall the only three > users did that), it's more nature to return the value in Hz and we > make a explicit comment there. Then we put the unit conversion inside > the sdhci core. Thus will improve the code and prevent further misues. > > [1]: https://patchwork.kernel.org/patch/9569431/ > Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx> > Cc: Anssi Hannula <anssi.hannula@xxxxxxxxxx> > Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> > For sdhci-cadence.c bit, Acked-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> Thanks! -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
