Am 15.02.2017 um 17:54 schrieb Kevin Hilman: > Heiner Kallweit <hkallweit1@xxxxxxxxx> writes: > >> CMD23 isn't supported on meson-gx and therefore the "set block count" >> command isn't used. So remove this dead code. > > I'm admittedly a bit unfamiliar with the MMC spec and wrote this driver > mostly by looking at the vendor driver, so forgive the silly > questions... > > Why isn't CMD23 supported, and should we support instead of deleting > this support? > As far as I understand this needs to be supported by the host controller. And setting the respective host flag to enable CMD23 mode lead to a non-working driver when testing on my system. > Kevin > >> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> >> --- >> drivers/mmc/host/meson-gx-mmc.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c >> index 1ad66f84..e89bdf5f 100644 >> --- a/drivers/mmc/host/meson-gx-mmc.c >> +++ b/drivers/mmc/host/meson-gx-mmc.c >> @@ -555,11 +555,7 @@ static void meson_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq) >> writel(0, host->regs + SD_EMMC_START); >> >> host->mrq = mrq; >> - >> - if (mrq->sbc) >> - meson_mmc_start_cmd(mmc, mrq->sbc); >> - else >> - meson_mmc_start_cmd(mmc, mrq->cmd); >> + meson_mmc_start_cmd(mmc, mrq->cmd); >> } >> >> static int meson_mmc_read_resp(struct mmc_host *mmc, struct mmc_command *cmd) >> @@ -690,7 +686,7 @@ static irqreturn_t meson_mmc_irq_thread(int irq, void *dev_id) >> } >> >> meson_mmc_read_resp(host->mmc, cmd); >> - if (!data || !data->stop || mrq->sbc) >> + if (!data || !data->stop) >> meson_mmc_request_done(host->mmc, mrq); >> else >> meson_mmc_start_cmd(host->mmc, data->stop); > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
