I just see the we put them everywhere, so the legacy code should be improved a bit for maintainability, especially for the sdio quirks case. Just split them into small patches to be better reviewed but I don't mind to squash them up.:) Changes in v3: - remove __maybe_unused and clean up the header files Changes in v2: - add __maybe_unused to make it cleanly compiled standalone suggested by Ulf - add inline for mmc_fixup_device - move INAND quirks together Shawn Lin (5): mmc: core: change quirks.c to be a header file mmc: core: move some sdio IDs out of quirks file mmc: core: improve the quirks for sdio devices mmc: core: move all quirks together into quirks.h mmc: core: add mmc prefix for blk_fixups drivers/mmc/core/Makefile | 2 +- drivers/mmc/core/block.c | 83 +----------------------- drivers/mmc/core/card.h | 2 - drivers/mmc/core/mmc.c | 12 +--- drivers/mmc/core/quirks.c | 85 ------------------------- drivers/mmc/core/quirks.h | 148 +++++++++++++++++++++++++++++++++++++++++++ drivers/mmc/core/sdio.c | 3 +- include/linux/mmc/sdio_ids.h | 7 ++ 8 files changed, 161 insertions(+), 181 deletions(-) delete mode 100644 drivers/mmc/core/quirks.c create mode 100644 drivers/mmc/core/quirks.h -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html