On 10 February 2017 at 10:41, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote: > On 2017/2/8 19:15, Ulf Hansson wrote: >> >> [...] >> >>> diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.h >>> similarity index 95% >>> rename from drivers/mmc/core/quirks.c >>> rename to drivers/mmc/core/quirks.h >>> index bf25a9c..f3bbfcb7 100644 >>> --- a/drivers/mmc/core/quirks.c >>> +++ b/drivers/mmc/core/quirks.h >> >> >> As you are rename this to become a header file, please also clean up >> the included headers from the new quirks.h. >> >> For example, you don't need these: >> >> #include <linux/kernel.h> >> #include <linux/export.h> >> >> Instead you need: >> #include <linux/device.h> >> #include <linux/string.h> >> > > Sure. > >> >>> @@ -53,7 +53,8 @@ >>> END_FIXUP >>> }; >>> >>> -void mmc_fixup_device(struct mmc_card *card, const struct mmc_fixup >>> *table) >>> +static inline void __maybe_unused >> >> >> The "__maybe_unused" shouldn't be needed here, or is it? >> > > I tried to keep a C file to include quirk.h to make sure it will > be compiled standalone cleanly. Otherwise the gcc cast a warning > with W=1 about "defined but not used".. I see. However those kind of warnings isn't relevant when compiling the header standalone. [...] Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
