On 7 February 2017 at 09:27, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote: > > I just see the we put them everywhere, so the legacy code > should be improved a bit for maintainability, especially for > the sdio quirks case. Just split them into small patches to be > better reviewed but I don't mind to squash them up. :) > > > > Shawn Lin (5): > mmc: core: change quirks.c to be a header file > mmc: core: move some sdio IDs out of quirks file > mmc: core: improve the quirks for sdio devices > mmc: core: move all quirks together into quirks.h > mmc: core: add mmc prefix for blk_fixups > > drivers/mmc/core/Makefile | 2 +- > drivers/mmc/core/block.c | 77 +---------------------- > drivers/mmc/core/card.h | 2 - > drivers/mmc/core/mmc.c | 12 +--- > drivers/mmc/core/quirks.c | 85 ------------------------- > drivers/mmc/core/quirks.h | 145 +++++++++++++++++++++++++++++++++++++++++++ > drivers/mmc/core/sdio.c | 3 +- > include/linux/mmc/sdio_ids.h | 7 +++ > 8 files changed, 158 insertions(+), 175 deletions(-) > delete mode 100644 drivers/mmc/core/quirks.c > create mode 100644 drivers/mmc/core/quirks.h > > -- > 1.9.1 Besides the comment for patch 1, this looks good to me. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
