On 1 February 2017 at 13:48, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> This function is doing to many clever things at the same time under
> too many various conditions.
>
> Start to make things clearer by refactoring: break out the
> finalization of the previous asynchronous request to its own
> function mmc_finalize_areq(). We can get rid of the default
> assignment of status and let the call deal with this.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> drivers/mmc/core/core.c | 65 ++++++++++++++++++++++++++++++++-----------------
> 1 file changed, 43 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index a160c3a7777a..41b4cd01fccc 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -631,6 +631,37 @@ static void mmc_post_req(struct mmc_host *host, struct mmc_request *mrq,
> }
>
> /**
> + * mmc_finalize_areq() - finalize an asynchronous request
> + * @host: MMC host to finalize any ongoing request on
> + * @ret_stat: the status of the ongoing asynchronous request:
This looks like a copy paste error as there is no ret_stat variable.
> + * will return MMC_BLK_SUCCESS if no request was
> + * going on.
> + */
> +static enum mmc_blk_status mmc_finalize_areq(struct mmc_host *host)
> +{
[...]
No need for you to re-spin, allow me to take care of the minor
nitpicks before I apply this.
Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
