On 01/27/2017 12:04 AM, Gerd Hoffmann wrote: > On Do, 2017-01-26 at 15:51 -0800, Florian Fainelli wrote: >> On 01/26/2017 03:37 PM, Gerd Hoffmann wrote: >>> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> >> >> Few things with your submission: >> >> - if you send more than one patch, a cover letter is a welcome to >> explain your changes > > There actually is a cover letter. The git-send-email "cccmd = > scripts/get_maintainer.pl" hook doesn't work for the cover letter though > because it isn't a patch. I've hand-picked some people who > touched/reviewed the driver before to the git-send-email command line, > but everybody else got the patches only. > > Anyone has a good solution for this btw? Do a dry run against all patches, collect the cclist in a file, and have a script that outputs one line, something like this: ./scripts/get_maintainer.pl patches/*.patch > cclist cclist.sh: #!/bin/sh cat $(dirname $0)/cclist git send-email --cc-cmd=cclist.sh patches/*.patch > >> - try to provide commit messages for things that are not obvious (in >> fact, most maintainers actually request commit messages even for trivial >> things) > > The driver is out of tree still, these are cleanups Ulf Hansson asked > for last time the driver was submitted. > > Full set of patches: > https://www.kraxel.org/cgit/linux/log/?h=bcm2837-sdhost-cleanup > > Plan for upstream merge is to actually squash all the incremental > cleanups, but for now I kept them as separate changes. I think this > makes it easier to spot mistakes and it'll also help in case there are > regressions b/c you can bisect things. > >> - have not we switched to the iproc SDHCI driver, or is this for the >> other SDIO connected peripherals here? > > The 2835 has two SD controllers: The Arasan SDHCI controller that we > currently use (iproc drives that one), and a custom SD controller. > > This is a driver for the custom one. Has better performance than the > sdhci controller (according to Eric Anholt). For the rpi3 switching to > this driver has the additional advantage that we can use the iproc > driver driver to handle the wifi. OK -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
