On 1/24/17, 4:36 PM, "Adrian Hunter" <adrian.hunter@xxxxxxxxx> wrote: On 23/01/17 19:07, Alex Lemberg wrote: > Hi Adrian, > > I would like to add several notes on top of Uri’s answer... > I agree with you, by the spec, PON Sleep_Notification should be > set before calling Sleep command. > As you probably remember, we have tried to implement it > in the past and even submitted a patch – “[PATCH] mmc: sleep notification” > https://www.mail-archive.com/linux-mmc@xxxxxxxxxxxxxxx/msg30906.html > As you can see from the thread, one of the main issues in Sleep_Notification > is a SLEEP_NOTIFICATION_TIME (defined in EXT_CSD [216]), which need to be > considered in implementation… Does it? I would tend to assume SLEEP_NOTIFICATION_TIME will be acceptable during _suspend until proven otherwise. Potentially, by the spec, the Max value of SLEEP_NOTIFICATION_TIME can be 83.88 seconds. Can we assume that this time is acceptable during _suspend? > Thus, I think postponing Sleep during suspend requires a different from current > AUTO_BKOPS implementation, and I suggest to handle it in separate > patchset, if possible. Not at all sure what you mean by "postponing Sleep"? I mean letting Sleep_Notification to be completed before Sleep. ��.n��������+%������w��{.n�����{��i��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥