Hi Shawn Thanks for the review, As you request I will add changelog and remove the Change-Id. I am afraid I didn't quite understand your remark about authorship and the SOB path, appreciate if you can elaborate on this. Thanks Uri -----Original Message----- From: Shawn Lin [mailto:shawn.lin@xxxxxxxxxxxxxx] Sent: Wednesday, January 18, 2017 3:54 AM To: Uri Yanai Cc: ulf.hansson@xxxxxxxxxx; shawn.lin@xxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; chris@xxxxxxxxxx; Alex Lemberg Subject: Re: [PATCH 0/3] Auto BKOPS PM suspend Hi Uri, On 2017/1/17 20:15, Uri Yanai wrote: > Hi Ulf > Resubmitting three patches for approval, originally submitted by Alex Lemberg <alex.lemberg@xxxxxxxxxxx> > [1/3] mmc: replacing hardcoded value for runtime PM suspend Message ID:<1472739890-3384-2-git-send-email-alex.lemberg@xxxxxxxxxxx> > [2/3] mmc: Adding AUTO_BKOPS_EN bit set for Auto BKOPS support Message ID:<1472739890-3384-3-git-send-email-alex.lemberg@xxxxxxxxxxx> > [3/3] mmc: Checking BKOPS status prior to Suspend Message ID:<1472739890-3384-4-git-send-email-alex.lemberg@xxxxxxxxxxx> > > Thanks > Uri Yanai Firstly, the authorship isn't correct and of course the SOB path. Then, it'd better to add a changelog since you do improve Alex's patches, and it would help us to better understand what was changed. :) Also you should remove Change-Id when fetching patches from your internal code review system. Anyway, let's talk about the patches themself, I have a question for your patch 3/3 there. > > Uri Yanai (3): > mmc: replacing hardcoded value for runtime PM suspend > mmc: Adding AUTO_BKOPS_EN bit set for Auto BKOPS support > mmc: Checking BKOPS status prior to Suspend > > drivers/mmc/core/block.c | 3 ++- > drivers/mmc/core/mmc.c | 45 ++++++++++++++++++++++++++++++++++++--------- > include/linux/mmc/card.h | 1 + > include/linux/mmc/host.h | 2 ++ > include/linux/mmc/mmc.h | 3 +++ > 5 files changed, 44 insertions(+), 10 deletions(-) > -- Best Regards Shawn Lin ��.n��������+%������w��{.n�����{��i��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
