On 16 January 2017 at 04:01, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote: > On 2017/1/13 21:14, Ulf Hansson wrote: >> >> A significant amount of functions are available through the public mmc >> core.h header file. Let's slim down this public mmc interface, as to >> prevent users from abusing it, by moving some of the functions to private >> mmc header files. >> >> This change concentrates on moving the functions into private mmc headers, >> following changes may continue with additional clean-ups, as an example >> some functions can be turned into static. >> > > [...] > >> @@ -16,6 +16,7 @@ >> #include <linux/mmc/sdio_func.h> >> >> #include "sdio_ops.h" >> +#include "core.h" >> > > Should we need move it before sdio_ops.h to > slightly keep the order? The same for sdio_orq.c change :) One of the points in this series is also to fix header dependencies properly. In other words, each header must be able to build standalone. This removes any constraints on the order of how we include them. To test each header for this, I have some local Makefiles and c-files. That said, I don't think there is an existing order we need or should maintain (unless because we think it looks nice). If that would be the case, it's should be considered as a bug. [...] Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
