On 11 January 2017 at 12:51, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > Changes in v2: > - As patch 1->11 was applied from version 1, those have been dropped > from the series. > - Folded in a new change in patch 1/12, to solve a build issue for imx > which is using the mxcmmc platform data header. > - Added reviews/acks. > > > Ideally we should not expose functions nor structures as being public available > as the interface for mmc - unless they really are intended to be used like that. > > Unfortunate this is not the case today and which has lead to the mmc interface > in some cases being abused. That of course has its own problems, but we can > still move things in the right direction, which is what this series intend to > do. More precisely, it moves things that can be easily moved from the public mmc > headers to the private mmc headers. > > This should be considered as a first step of improving the situation, further > additional changes will have to continue this path. > > > Ulf Hansson (12): > mmc: mxcmmc: Include interrupt.h in the platform data header > mmc: core: First step in cleaning up public mmc header files > mmc: core: First step in cleaning up private mmc header files > mmc: core: Move public functions from core.h to private headers > mmc: core: Move some host specific public functions to host.h > mmc: core: Move erase/trim/discard defines from public core.h to mmc.h > mmc: core: Remove unused struct _mmc_csd from public mmc.h header > mmc: omap: Don't use mmc_card_present() when validating for inserted > card > mmc: vub300: Don't use mmc_card_present() when validating for inserted > card > mmc: core: Move public functions from card.h to private headers > mmc: core: Move public functions from host.h to private headers > mmc: core: Don't use extern declarations of public mmc functions > > drivers/mmc/core/block.c | 6 + > drivers/mmc/core/block.h | 8 + > drivers/mmc/core/bus.c | 2 + > drivers/mmc/core/bus.h | 16 +- > drivers/mmc/core/card.h | 223 ++++++++++++++++++++++++++++ > drivers/mmc/core/core.c | 1 + > drivers/mmc/core/core.h | 41 +++++- > drivers/mmc/core/debugfs.c | 2 + > drivers/mmc/core/host.h | 48 ++++++ > drivers/mmc/core/mmc.c | 13 ++ > drivers/mmc/core/mmc_ops.h | 14 ++ > drivers/mmc/core/mmc_test.c | 5 + > drivers/mmc/core/pwrseq.h | 6 +- > drivers/mmc/core/queue.c | 2 + > drivers/mmc/core/queue.h | 6 +- > drivers/mmc/core/quirks.c | 2 + > drivers/mmc/core/sd.c | 2 + > drivers/mmc/core/sd.h | 5 +- > drivers/mmc/core/sd_ops.h | 9 ++ > drivers/mmc/core/sdio.c | 2 + > drivers/mmc/core/sdio_bus.c | 1 + > drivers/mmc/core/sdio_bus.h | 3 + > drivers/mmc/core/sdio_cis.h | 3 + > drivers/mmc/core/sdio_io.c | 2 + > drivers/mmc/core/sdio_irq.c | 2 + > drivers/mmc/core/sdio_ops.h | 5 + > drivers/mmc/core/slot-gpio.h | 2 + > drivers/mmc/host/omap.c | 2 +- > drivers/mmc/host/vub300.c | 6 +- > include/linux/mmc/card.h | 242 ------------------------------- > include/linux/mmc/core.h | 86 ++--------- > include/linux/mmc/host.h | 63 ++------ > include/linux/mmc/mmc.h | 59 ++------ > include/linux/mmc/slot-gpio.h | 3 + > include/linux/platform_data/mmc-mxcmmc.h | 1 + > 35 files changed, 467 insertions(+), 426 deletions(-) > create mode 100644 drivers/mmc/core/card.h > > -- > 1.9.1 > I have now applied this for next to get it well tested. Please tell asap, if you have any objections. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html