Re: [PATCH v2 2/2] mmc: mediatek: correct the implementation of msdc_card_busy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3 January 2017 at 09:49, Yong Mao <yong.mao@xxxxxxxxxxxx> wrote:
> From: yong mao <yong.mao@xxxxxxxxxxxx>
>
> msdc_card_busy only need check if the data0 is low.
> In sdio data1 irq mode, data1 may be low because of interruption.
>
> Signed-off-by: Yong Mao <yong.mao@xxxxxxxxxxxx>
> Signed-off-by: Chaotian Jing <chaotian.jing@xxxxxxxxxxxx>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/mtk-sd.c |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 10ef2ae..80ba034 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1074,11 +1074,8 @@ static int msdc_card_busy(struct mmc_host *mmc)
>         struct msdc_host *host = mmc_priv(mmc);
>         u32 status = readl(host->base + MSDC_PS);
>
> -       /* check if any pin between dat[0:3] is low */
> -       if (((status >> 16) & 0xf) != 0xf)
> -               return 1;
> -
> -       return 0;
> +       /* only check if data0 is low */
> +       return !(status & BIT(16));
>  }
>
>  static void msdc_request_timeout(struct work_struct *work)
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux