-trimmed cc list (future wise, I suggest you be more careful whom to keep on cc/to) On 12 January 2017 at 11:04, Yong Mao <yong.mao@xxxxxxxxxxxx> wrote: > From: yong mao <yong.mao@xxxxxxxxxxxx> > > Add description for hs200-cmd-int-delay > Add description for hs400-cmd-int-delay > Add description for cmd-resp-sel > > Signed-off-by: Yong Mao <yong.mao@xxxxxxxxxxxx> The changes to DTS bindings should come prior the actual code change using the bindings. Please make this patch 1 instead. Otherwise this looks good to me. Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 0120c7f..2dbb3b0 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -21,6 +21,9 @@ Optional properties: > - assigned-clocks: PLL of the source clock > - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock > - hs400-ds-delay: HS400 DS delay setting > +- hs200-cmd-int-delay: HS200 command internal delay setting > +- hs400-cmd-int-delay: HS400 command internal delay setting > +- cmd-resp-sel: command response sample selection > > Examples: > mmc0: mmc@11230000 { > @@ -38,4 +41,7 @@ mmc0: mmc@11230000 { > assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>; > hs400-ds-delay = <0x14015>; > + hs200-cmd-int-delay = <26>; > + hs400-cmd-int-delay = <14>; > + cmd-resp-sel = <0>; /* 0: rising, 1: falling */ > }; > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html