On Fri, Dec 30, 2016 at 12:39:45PM +0100, Ulf Hansson wrote: > To validate whether native hotplug is intended to be used, the tmio driver > checks whether the GPIO isr has been successfully assigned. This isn't > entirely correct, as GPIO could still be used for card detect, but in a > polling mode. Isn't that checked with MMC_CAP_NEEDS_POLL? Could we maybe get rid of that then? > > Therefore, let's convert to use the correct mmc interface, > mmc_can_gpio_cd() as it tells exactly what we need for the native hotplug > validation. > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > --- > drivers/mmc/host/tmio_mmc_pio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c > index 3ca97f3..580ca9c 100644 > --- a/drivers/mmc/host/tmio_mmc_pio.c > +++ b/drivers/mmc/host/tmio_mmc_pio.c > @@ -1178,7 +1178,7 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host, > _host->native_hotplug = !(pdata->flags & TMIO_MMC_USE_GPIO_CD || > mmc->caps & MMC_CAP_NEEDS_POLL || > !mmc_card_is_removable(mmc) || > - mmc->slot.cd_irq >= 0); > + mmc_can_gpio_cd(mmc)); > > /* > * On Gen2+, eMMC with NONREMOVABLE currently fails because native > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
