On 21 December 2016 at 11:06, Y.B. Lu <yangbo.lu@xxxxxxx> wrote: > Hi Uffe, > > Did you have a chance to look at this? > Thanks a lot:) Please resend/rebase once rc1 is out, and make sure to have Adrian in the to field. Then I will wait for his ack. Kind regards Uffe > > Best regards, > Yangbo Lu > >> -----Original Message----- >> From: Y.B. Lu >> Sent: Friday, December 09, 2016 11:24 AM >> To: 'linux-mmc@xxxxxxxxxxxxxxx'; 'ulf.hansson@xxxxxxxxxx' >> Cc: X.B. Xie >> Subject: RE: [PATCH 1/2] mmc: sdhci-esdhc: clean up register definitions >> >> Hi Uffe, >> >> Could you help to review and merge these two patches? >> Thanks. >> >> >> Best regards, >> Yangbo Lu >> >> > -----Original Message----- >> > From: Y.B. Lu >> > Sent: Friday, December 02, 2016 10:37 AM >> > To: linux-mmc@xxxxxxxxxxxxxxx; ulf.hansson@xxxxxxxxxx >> > Cc: X.B. Xie >> > Subject: RE: [PATCH 1/2] mmc: sdhci-esdhc: clean up register >> > definitions >> > >> > Any comments on this patchset? >> > Thanks. >> > >> > >> > Best regards, >> > Yangbo Lu >> > >> > > -----Original Message----- >> > > From: Yangbo Lu [mailto:yangbo.lu@xxxxxxx] >> > > Sent: Friday, November 25, 2016 12:01 PM >> > > To: linux-mmc@xxxxxxxxxxxxxxx; ulf.hansson@xxxxxxxxxx >> > > Cc: Xiaobo Xie; Y.B. Lu >> > > Subject: [PATCH 1/2] mmc: sdhci-esdhc: clean up register definitions >> > > >> > > The eSDHC register definitions in header file were messy and >> confusing. >> > > This patch is to clean up these definitions. >> > > >> > > Signed-off-by: Yangbo Lu <yangbo.lu@xxxxxxx> >> > > --- >> > > drivers/mmc/host/sdhci-esdhc.h | 39 >> > > ++++++++++++++++++++---------------- >> > > --- >> > > 1 file changed, 20 insertions(+), 19 deletions(-) >> > > >> > > diff --git a/drivers/mmc/host/sdhci-esdhc.h >> > > b/drivers/mmc/host/sdhci- esdhc.h index de132e2..8cd8449 100644 >> > > --- a/drivers/mmc/host/sdhci-esdhc.h >> > > +++ b/drivers/mmc/host/sdhci-esdhc.h >> > > @@ -24,30 +24,31 @@ >> > > SDHCI_QUIRK_PIO_NEEDS_DELAY | \ >> > > SDHCI_QUIRK_NO_HISPD_BIT) >> > > >> > > -#define ESDHC_PROCTL 0x28 >> > > - >> > > -#define ESDHC_SYSTEM_CONTROL 0x2c >> > > -#define ESDHC_CLOCK_MASK 0x0000fff0 >> > > -#define ESDHC_PREDIV_SHIFT 8 >> > > -#define ESDHC_DIVIDER_SHIFT 4 >> > > -#define ESDHC_CLOCK_PEREN 0x00000004 >> > > -#define ESDHC_CLOCK_HCKEN 0x00000002 >> > > -#define ESDHC_CLOCK_IPGEN 0x00000001 >> > > - >> > > /* pltfm-specific */ >> > > #define ESDHC_HOST_CONTROL_LE 0x20 >> > > >> > > /* >> > > - * P2020 interpretation of the SDHCI_HOST_CONTROL register >> > > + * eSDHC register definition >> > > */ >> > > -#define ESDHC_CTRL_4BITBUS (0x1 << 1) >> > > -#define ESDHC_CTRL_8BITBUS (0x2 << 1) >> > > -#define ESDHC_CTRL_BUSWIDTH_MASK (0x3 << 1) >> > > - >> > > -/* OF-specific */ >> > > -#define ESDHC_DMA_SYSCTL 0x40c >> > > -#define ESDHC_DMA_SNOOP 0x00000040 >> > > >> > > -#define ESDHC_HOST_CONTROL_RES 0x01 >> > > +/* Protocol Control Register */ >> > > +#define ESDHC_PROCTL 0x28 >> > > +#define ESDHC_CTRL_4BITBUS (0x1 << 1) >> > > +#define ESDHC_CTRL_8BITBUS (0x2 << 1) >> > > +#define ESDHC_CTRL_BUSWIDTH_MASK (0x3 << 1) >> > > +#define ESDHC_HOST_CONTROL_RES 0x01 >> > > + >> > > +/* System Control Register */ >> > > +#define ESDHC_SYSTEM_CONTROL 0x2c >> > > +#define ESDHC_CLOCK_MASK 0x0000fff0 >> > > +#define ESDHC_PREDIV_SHIFT 8 >> > > +#define ESDHC_DIVIDER_SHIFT 4 >> > > +#define ESDHC_CLOCK_PEREN 0x00000004 >> > > +#define ESDHC_CLOCK_HCKEN 0x00000002 >> > > +#define ESDHC_CLOCK_IPGEN 0x00000001 >> > > + >> > > +/* Control Register for DMA transfer */ >> > > +#define ESDHC_DMA_SYSCTL 0x40c >> > > +#define ESDHC_DMA_SNOOP 0x00000040 >> > > >> > > #endif /* _DRIVERS_MMC_SDHCI_ESDHC_H */ >> > > -- >> > > 2.1.0.27.g96db324 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
