Re: [PATCH 1/1] mmc: core: Further fix thread wake-up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tuesday, December 20, 2016 11:56:23 AM Ulf Hansson wrote:
> On 19 December 2016 at 14:57, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
> > Commit e0097cf5f2f1 ("mmc: queue: Fix queue thread wake-up") did not go far
> > enough. mmc_wait_for_data_req_done() still contains some problems and can
> > be further simplified.  First it should not touch
> > context_info->is_waiting_last_req because that is a wake-up control used by
> > the owner of the context. Secondly, it should always return when one of its
> > wake-up conditions is met because, again, that is contolled by the owner of
> > the context.
> >
> > While the current block driver does not have an issue, these problems were
> > exposed during testing of the Software Command Queue patches.

This sentence no longer seems to be true..

> > Fixes: e0097cf5f2f1 ("mmc: queue: Fix queue thread wake-up")
> > Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> 
> Thanks, applied for fixes!

Seems that I'm late but FWIW for the patch content:

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux