On 9 December 2016 at 01:14, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote: > Dear Ulf, > > On 12/09/2016 08:48 AM, Ulf Hansson wrote: >> Once upon a time it made sense to keep the mmc block device driver and its >> related code, in its own directory called card. Over time, more an more >> functions/structures have become shared through generic mmc header files, >> between the core and the card directory. In other words, the relationship >> between them has become closer. >> >> By sharing functions/structures via generic header files, it becomes easy >> for outside users to abuse them. In a way to avoid that from happen, let's >> move the files from card directory into the core directory, as it enables >> us to move definitions of functions/structures into mmc core specific >> header files. >> >> Note, this is only the first step in providing a cleaner mmc interface for >> outside users. Following changes will do the actual cleanup, as that is not >> part of this change. > > Just minor question, Does it keep the below comments? > > drivers/mmc/core/mmc_test.c:2: * linux/drivers/mmc/card/mmc_test.c > drivers/mmc/core/queue.c:2: * linux/drivers/mmc/card/queue.c > drivers/mmc/core/sdio_uart.c:2: * linux/drivers/mmc/card/sdio_uart.c - SDIO UART/GPS driver > > After moving files to core, can they be changed? > Is it more comfortable than changing now? I have applied this change for my next branch, with the changes you recommend above. Thanks for noticing this! I will send a second PR for 4.10, with only this change - as to get a nice and fresh start for 4.11. [...] Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
