Hi Julia, On 2016/12/10 3:08, Julia Lawall wrote: > Device node iterators put the previous value of the index variable, so an > explicit put causes a double put. > > Generated by: scripts/coccinelle/iterators/device_node_continue.cocci > > CC: Hu Ziji <huziji@xxxxxxxxxxx> > Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx> > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> > --- > > Please check on this. I have only seen the code shown below, but the rule > normally has a lot false positive rate. > Thank you. It seems that the check is right. I will correct it. Thank you. Best regards, Hu Ziji > url: > https://github.com/0day-ci/linux/commits/Gregory-CLEMENT/mmc-Add-support-to-Marvell-Xenon-SD-Host-Controller/20161210-002602 > base: > :::::: branch date: 2 hours ago > :::::: commit date: 2 hours ago > > > Please take the patch only if it's a positive warning. Thanks! > > sdhci-xenon.c | 1 - > 1 file changed, 1 deletion(-) > > --- a/drivers/mmc/host/sdhci-xenon.c > +++ b/drivers/mmc/host/sdhci-xenon.c > @@ -423,7 +423,6 @@ static int xenon_child_node_of_parse(str > MMC_CAP2_NO_SD | > MMC_CAP2_NO_SDIO; > } > - of_node_put(child); > } > > return 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html