On 8 December 2016 at 12:45, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > On 08/12/16 13:18, Ulf Hansson wrote: >> Once upon a time it made sense to keep the mmc block device driver and its >> related code, in a separate directory. Over time, more an more interfaces >> and structures have been exported by the core layer to outsiders. This to >> allow the mmc block device driver to do its job. In other words, the >> relationship between the block code and the core code has become closer. >> >> Let's not continue this path, but instead let's join the two directories. >> Simply by moving the block files into the core directory, lots of clean ups >> can be made, but more importantly, this change should also enables us >> remove unnecessary exported interfaces. > > Don't you still need to export things if they are separate modules? Yes, right! Perhaps I was a bit too vague in my change-log. I aim to slim down generic mmc headers in include/linux/mmc/* as to achieve the goal of only providing interfaces/structures to outsiders which they are allowed to use. Currently it's it too easy to abuse the mmc interfaces. BTW, regarding your eMMC CMDQ series, that can easily be re-based on top of this change as git takes good care of files being renamed. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html