On 01/12/16 16:57, Ulf Hansson wrote: > On 1 December 2016 at 15:04, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: >> Hi >> >> Here are some tidy-ups wrt SDHCI tuning. Un-tested so far. > > Nice. Thanks! > >> >> Any other suggestions? Otherwise I will test and submit the whole series. > > As an additional step, could you try to make use of mmc_send_tuning(), > instead of sending the command internally from sdhci_send_tuning()? mmc_send_tuning() is not a good fit. SDHCI tuning command does not have a data payload (or rather the hardware does it automatically) so unless mmc_send_tuning() is changed it will return -EIO. If that is changed then, SDHCI request function needs to be changed to special-case the tuning command because the interrupt setup is different. Then the problem is that there is no timeout interrupt so another timer is needed, so a special case would have to be created for that too. The current code is much simpler. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
