+Alex
On 30 November 2016 at 10:10, Thierry Escande
<thierry.escande@xxxxxxxxxxxxx> wrote:
> Hi Jaehoon,
>
> On 30/11/2016 09:46, Jaehoon Chung wrote:
>>
>> On 11/29/2016 11:24 PM, Thierry Escande wrote:
>>>
>>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
>>> index df19777..774d478 100644
>>> --- a/drivers/mmc/core/mmc.c
>>> +++ b/drivers/mmc/core/mmc.c
>>> @@ -1941,8 +1941,14 @@ static int _mmc_suspend(struct mmc_host *host,
>>> bool is_suspend)
>>> if (mmc_can_poweroff_notify(host->card) &&
>>> ((host->caps2 & MMC_CAP2_FULL_PWR_CYCLE) || !is_suspend))
>>> err = mmc_poweroff_notify(host->card, notify_type);
>>> - else if (mmc_can_sleep(host->card))
>>> + else if (mmc_can_sleep(host->card)) {
>>> + if (host->card->quirks &
>>> MMC_QUIRK_NOTIFY_POWEROFF_ON_SLEEP) {
>>> + err = mmc_poweroff_notify(host->card,
>>> notify_type);
>>> + if (err)
>>> + goto out;
>>> + }
>>> err = mmc_sleep(host);
>>
>>
>> After running mmc_poweroff_notify(), also doing mmc_sleep()? Is it right?
>
>
> Yes, that's what the quirk is intended for. This firmware resumes from sleep
> faster if it has been notified for power-off. This is a recommendation from
> Hynix.
I think we need to discuss this change in the context of eMMC sleep
notification - as a generic solution and conforming to the eMMC spec.
This was also as pointed out by Alex [1]. Perhaps you can respond to
his earlier reply?
>
> Regards,
> Thierry
Kind regards
Uffe
[1]
http://www.spinics.net/lists/linux-mmc/msg39892.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
