Re: [PATCH V7 06/25] mmc: queue: Introduce queue depth

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/11/2016 4:43 p.m., Linus Walleij wrote:
On Fri, Nov 25, 2016 at 11:07 AM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:

Add a mmc_queue member to record the size of the queue, which currently
supports 2 requests on-the-go at a time.

Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
(...)
+       /* Queue depth is only ever 2 with packed commands */

That's a weird comment.
It doesn't have anything with packed commands to do does it?

No it doesn't. Packed commands and command queue are mutually exclusive, but the packed commands implementation expects there to be 2 mmc_queue_req's. Adding a check was just for the code to protect itself from oops.

In that case it was just deleted.

Yes, I will re-base.


Are you referring to the asynchronous issuing pipeline thing
(cur & next)?

Yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux