On Fri, Nov 25, 2016 at 11:07 AM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > The 4K native sector check does not allow for the 'do' loop nor the > variables used after the 'cmd_abort' label. > > 'brq' and 'req' get reassigned in the 'do' loop, so the check must not > assume what their values are. After the 'cmd_abort' label, 'mq_rq' and > 'req' are used, but 'rqc' must be NULL otherwise it can be started again. > > Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Looks correct, and is clearly a sign of what we all know: mmc_blk_issue_rw_rq() is hopelessly convoluted and needs to be refactored into something we can read. Shouldn't this patch just be moved to the front of the patch queue and merged as a fix? AFAICT it's a plain bug. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
