Hi jaehoon,
On 11/25/2016 11:37 AM, Jaehoon Chung wrote:
> Hi Joonyoung,
>
> On 11/23/2016 06:33 PM, Joonyoung Shim wrote:
>> The commit 64997de4fd17 ("mmc: dw_mmc: remove system PM callback") is
>> missing to call dw_mci_ctrl_reset(). This adds to call
>> dw_mci_ctrl_reset() and to handle error of clocks.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
>
> Applied on my dwmmc repository. Thanks!
>
Thanks, but i found one more issue.
> Best Regards,
> Jaehoon Chung
>
>> ---
>> drivers/mmc/host/dw_mmc.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index d426fa41bcce..25e21a20ee04 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -3303,6 +3303,17 @@ int dw_mci_runtime_resume(struct device *dev)
>> if (ret)
>> return ret;
Here, error handling about biu_clk should be consider.
>>
>> + if (!dw_mci_ctrl_reset(host, SDMMC_CTRL_ALL_RESET_FLAGS)) {
>> + clk_disable_unprepare(host->ciu_clk);
>> +
>> + if (host->cur_slot &&
>> + (mmc_can_gpio_cd(host->cur_slot->mmc) ||
>> + !mmc_card_is_removable(host->cur_slot->mmc)))
>> + clk_disable_unprepare(host->biu_clk);
>> +
>> + return -ENODEV;
>> + }
>> +
>> if (host->use_dma && host->dma_ops->init)
>> host->dma_ops->init(host);
>>
>>
I will send patch v2, could you review and apply patch v2 instead of v1?
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
