在 2016/11/18 19:45, Ulf Hansson 写道:
Hi Shawn,
On 18 November 2016 at 09:05, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
Hi Ulf,
在 2016/11/16 18:51, Ulf Hansson 写道:
In cases when the mmc host doesn't support HW busy detection, polling for
busy by using CMD13 is beneficial. The reasons have already been explained
in earlier change logs.
To allow polling with CMD13, let's provide MMC_TIMING_MMC_HS200 as the
timing parameter to __mmc_switch(), which makes sure the mmc host and the
mmc card operates at the same bus timing during the polling.
Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
---
drivers/mmc/core/mmc.c | 21 +++++----------------
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 3268fcd..0b26383 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1351,7 +1351,7 @@ static void mmc_select_driver_type(struct mmc_card
*card)
static int mmc_select_hs200(struct mmc_card *card)
{
struct mmc_host *host = card->host;
- unsigned int old_timing, old_signal_voltage;
+ unsigned int old_signal_voltage;
int err = -EINVAL;
u8 val;
@@ -1378,22 +1378,11 @@ static int mmc_select_hs200(struct mmc_card *card)
card->drive_strength << EXT_CSD_DRV_STR_SHIFT;
err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
EXT_CSD_HS_TIMING, val,
- card->ext_csd.generic_cmd6_time, 0,
- true, false, true);
- if (err)
- goto err;
- old_timing = host->ios.timing;
- mmc_set_timing(host, MMC_TIMING_MMC_HS200);
-
- err = mmc_switch_status(card);
- /*
- * mmc_select_timing() assumes timing has not changed if
- * it is a switch error.
- */
- if (err == -EBADMSG)
- mmc_set_timing(host, old_timing);
+ card->ext_csd.generic_cmd6_time,
+ MMC_TIMING_MMC_HS200,
+ true, true, true);
I was finding a failure from the test last night after applying these
patches and using HS200 only.
It seems like the controller(sdhci-of-arasan,5.1) continuously generate
response timeout for checking CMD13.. Per TRM, response timeout could
means the device didn't ack the CMD13 or the controller was failing to
latch the response..
Did you make any changes to the sdchi driver while testing this?
Nope, I didn't.
What I am wondering is whether you tested this with an implemented
->card_busy() host ops or not, as sdhci has a default implementation
of it.
yes, I was using sdhci's default card_busy callback.
I haven't reproduced that failure until now. :(
BTW, some sdhci hosts have lately shown problem [1] with sdhci's
default ->card_busy() host ops.
The eMMC part number is KLMBG2JENB-B041. I will use two boards to check
if it was indeed related to these patches.
}
-err:
+
if (err) {
/* fall back to the old signal voltage, if fails report
error */
if (__mmc_set_signal_voltage(host, old_signal_voltage))
--
Best Regards
Shawn Lin
Thanks for helping out with testing etc, I really appreciate it!
Kind regards
Uffe
[1]
https://patchwork.kernel.org/patch/9429299/
--
Best Regards
Shawn Lin
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
