On Tue, Nov 22, 2016 at 1:30 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Tue, Nov 22, 2016 at 11:31 AM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: >> I should have been more explicit. SW CMDQ covers some of the same ground >> and has basically the same patch: >> >> https://marc.info/?l=linux-mmc&m=147729859922297&w=2 > > OK it seems to define more of the constants, I'll go and review it. Bah it's not in my INBOX for some reason, maybe I fell off the linux-mmc list at some point :( I review it here: Leave out this: + cmdq_en Command Queue enabled: 1 => enabled, 0 => not enabled (...) +MMC_DEV_ATTR(cmdq_en, "%d\n", card->ext_csd.cmdq_en); (...) + &dev_attr_cmdq_en.attr, (...) + bool cmdq_en; /* Command Queue enabled */ Because that is about enabling the *use* of this mechnism rather than detecting its presence. With the above removed it is superior to $SUBJECT so you can add: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
