Hi Jaehoon,
On 2016/10/18 8:24, Jaehoon Chung wrote:
Hi Shawn,
On 10/12/2016 11:50 AM, Shawn Lin wrote:
Hi Jaehoon and Ulf,
This patch is gonna support runtime PM for dw_mmc.
It could support to disable ciu_clk by default and disable
biu_clk if the devices are non-removeable, or removeable
with gpio-base card detect.
Then I remove the system PM since the runtime PM actually
does the same thing as it. So I help migrate the dw_mmc variant
drivers to use runtime PM pairs and pm_runtime_force_*. Note
that I only enable runtime PM for dw_mmc-rockchip as I will
leave the decision to the owners of the corresponding drivers.
I just tested it on my RK3288 platform with linux-next to make
the runtime PM and system PM work fine for my emmc, sd card and
sdio. But I don't have hardware to help test other variant drivers.
But in theory it should work fine as I mentioned that the runtime
PM does the same thing as system PM except for disabling ciu_clk
aggressively which should not be related to the variant hosts.
As you could see that I just extend the slot-gpio a bit, so the
ideal way is Ulf could pick them up with Jaehoon's ack. :)
I have tested with my boards..it's working fine..I will apply on this if there is no special issue.
Great to hear this. The test for this patchset have been running for a
while on my rk3288/3368 boards and it seems no failures were found
until now.
Thanks!
Thanks!
Best Regards,
Jaehoon Chung
Changes in v2:
- use struct device as argument for runtime callback
- use dw_mci_runtime_* directly
- use dw_mci_runtime_* directly
- minor fix since I change the argument for dw_mci_runtime_*
- use dw_mci_runtime_* directly
- use dw_mci_runtime_* directly
Shawn Lin (9):
mmc: dw_mmc: add runtime PM callback
mmc: dw_mmc-rockchip: add runtime PM support
mmc: core: expose the capability of gpio card detect
mmc: dw_mmc: disable biu clk if possible
mmc: dw_mmc-k3: deploy runtime PM facilities
mmc: dw_mmc-exynos: deploy runtime PM facilities
mmc: dw_mmc-pci: deploy runtime PM facilities
mmc: dw_mmc-pltfm: deploy runtime PM facilities
mmc: dw_mmc: remove system PM callback
drivers/mmc/core/slot-gpio.c | 8 +++++++
drivers/mmc/host/dw_mmc-exynos.c | 24 +++++++++-----------
drivers/mmc/host/dw_mmc-k3.c | 39 ++++++++------------------------
drivers/mmc/host/dw_mmc-pci.c | 29 ++++++++----------------
drivers/mmc/host/dw_mmc-pltfm.c | 28 +++++++----------------
drivers/mmc/host/dw_mmc-rockchip.c | 42 +++++++++++++++++++++++++++++++---
drivers/mmc/host/dw_mmc.c | 46 +++++++++++++++++++++++++-------------
drivers/mmc/host/dw_mmc.h | 6 ++---
include/linux/mmc/slot-gpio.h | 1 +
9 files changed, 117 insertions(+), 106 deletions(-)
--
Best Regards
Shawn Lin
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
