On 6 September 2016 at 03:59, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote: > Hi Ulf, > > On 2016/9/2 19:30, Ulf Hansson wrote: >> >> In cases when the host->max_busy_timeout isn't specified, the calculated >> number of maximum discard sectors defaults to UINT_MAX. This may cause a >> too long timeout for a discard request. > > > > There is a android specific case(aka recovery stage) which may stuck IO > routine for a very long time (I saw 7 mins for the wrost case) . After > flashing ROM or factory reset, it will wipe a large number of sectors > with secure tag[0]. We can image that we may do secdiscard for a 100GB > free disk and unfortunately the max_busy_timeout isn't specified. It's > probably ok as on recovery stage there are no other tasks competing for > the IO and we hope the wipe action could finish ASAP. But if this case > happens for normal runing time, the system/user-space will be broken > anyway for waiting for such a long time. So this patch looks sane. Okay, I have queued this up for next and added your reviewed-by tag. > > > [0]: > https://android.googlesource.com/platform/system/extras/+/61d6591/ext4_utils/wipe.c > Thanks for the information. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
