On 30 August 2016 at 12:20, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
> On 30/08/16 13:02, Ulf Hansson wrote:
>> The commit 1ef5e49e46b9 ("mmc: sdhci-of-esdhc: add/remove some quirks
>> according to vendor version") moved sdhci-of-esdhc away from using the
>> ->platform_init() callback.
>>
>> As it was the only user of it and that it seems reasonable to believe that
>> it won't be needed again, let's remove just remove it.
>>
>> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>
> Have been meaning to do that, but didn't have time:
>
> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>
> However if you have spare time ;-) you could take a look at the Software
> Command Queue patches, at least the support for sending commands during data
> transfer:
Yes, I have briefly started. I postponed some of the more heavy
reviews to be able to catch up with all the simpler changes.
Allow me to get few more days, then I will respond to them!
BTW, I was also hoping Ritesh could help to review the changes.
Perhaps you can ping him as well.
Thanks and kind regards
Uffe
>
> http://marc.info/?l=linux-mmc&m=147134458618542
>
>> ---
>> drivers/mmc/host/sdhci-pltfm.c | 7 -------
>> drivers/mmc/host/sdhci.h | 1 -
>> 2 files changed, 8 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
>> index 1d17dcf..ad49bfa 100644
>> --- a/drivers/mmc/host/sdhci-pltfm.c
>> +++ b/drivers/mmc/host/sdhci-pltfm.c
>> @@ -156,13 +156,6 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
>> host->quirks2 = pdata->quirks2;
>> }
>>
>> - /*
>> - * Some platforms need to probe the controller to be able to
>> - * determine which caps should be used.
>> - */
>> - if (host->ops && host->ops->platform_init)
>> - host->ops->platform_init(host);
>> -
>> platform_set_drvdata(pdev, host);
>>
>> return host;
>> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
>> index 0411c9f..a2bc9e1 100644
>> --- a/drivers/mmc/host/sdhci.h
>> +++ b/drivers/mmc/host/sdhci.h
>> @@ -555,7 +555,6 @@ struct sdhci_ops {
>> void (*set_uhs_signaling)(struct sdhci_host *host, unsigned int uhs);
>> void (*hw_reset)(struct sdhci_host *host);
>> void (*adma_workaround)(struct sdhci_host *host, u32 intmask);
>> - void (*platform_init)(struct sdhci_host *host);
>> void (*card_event)(struct sdhci_host *host);
>> void (*voltage_switch)(struct sdhci_host *host);
>> int (*select_drive_strength)(struct sdhci_host *host,
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
