Re: Re: [PATCH RESEND] mmc: core: add error message when switching fails in mmc_select_hs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

>> @@ -1018,6 +1018,7 @@ static int mmc_switch_status(struct mmc_card *card)
>>   */
>>  static int mmc_select_hs(struct mmc_card *card)
>>  {
>> +       struct mmc_host *host = card->host;
> 
>No need for local variable here, just use card->host below instead.

Yes, it should be.
 
>>         int err;
>>
>>         err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
>> @@ -1029,6 +1030,10 @@ static int mmc_select_hs(struct mmc_card *card)
>>                 err = mmc_switch_status(card);
>>         }
>>
>> +       if (err)
>> +               pr_err("%s: switch to high-speed failed, err:%d\n",
>> +                       mmc_hostname(host), err);
> 
>I think a pr_warn() would be better as mmc_select_timing() uses the
>legacy speed mode when err == -EBADMSG.

I agree. A modified patch will be sent right after. 
Thanks for your comment.

>> +
>>         return err;
>>  }
>>
> 
>Kind regards
>Uffe
 
 

[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux