Hi Mark, On Mon, Aug 01, 2016 at 04:30:19PM +0100, Mark Rutland wrote: > On Mon, Aug 01, 2016 at 03:10:29PM +0200, Jean-Francois Moine wrote: > > Some MMC devices as mmc2 in the A83T or mmc1 and mmc2 in the H3 have > > a 'New Timings' mode. > > Set this capacity in the DT and use it when possible. > > What exactly is this "New Timings" mode? > > Why do we wnat to set it? Improved performance, power? Allwinner calls it under a rather generic name: "new mode" (which is of course the opposite of the old mode). In the old mode, the rate and phase controls were all handled by the functional clock feeding the MMC controller. In the new mode, the MMC controller itself is able to do some sort of auto-calibration to adjust the rate and phase of the clock output on the MMC bus. > Is it *necessary* to use it? Yes. Allwinner recommends to use it to enhance the compatibility with MMC cards, and they say that it also improves the performances, even though no one really checked. The main point for us at the moment is that some eMMCs at least require the new mode to operate properly. > > Signed-off-by: Jean-Francois Moine <moinejf@xxxxxxx> > > --- > > I don't know if this mode works or is needed at 25MHz. > > --- > > Documentation/devicetree/bindings/mmc/sunxi-mmc.txt | 1 + > > drivers/mmc/host/sunxi-mmc.c | 21 +++++++++++++++++++-- > > 2 files changed, 20 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt > > index 4bf41d8..a541bf4 100644 > > --- a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt > > +++ b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt > > @@ -19,6 +19,7 @@ Optional properties: > > - reset-names : must contain "ahb" > > - for cd, bus-width and additional generic mmc parameters > > please refer to mmc.txt within this directory > > + - allwinner,new-timings: the controller may accept the "New Timings" mode > > It's not at all clear to me what this means. This needs a better > description. > > Which devices have this? Can we determine this based on compatible > string? On some SoCs, yes, on some, no. The older SoCs (everything up to A80) only have the old mode, so the compatible works there. The newer SoCs (H3, A64) support the new mode on all their MMC controllers, so the compatible works too. However, in the SoC Jean-Francois is currently working on, the A83T, the new mode is only found in one (over three) controller. So I really think we need a property to express this, at least in the A83T case. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
