Hi Scott, > -----Original Message----- > From: Scott Wood [mailto:oss@xxxxxxxxxxxx] > Sent: Friday, July 22, 2016 12:45 AM > To: Michael Ellerman; Arnd Bergmann > Cc: linux-mmc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linuxppc- > dev@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Yangbo Lu > Subject: Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to > include/linux/fsl > > On Thu, 2016-07-21 at 20:26 +1000, Michael Ellerman wrote: > > Quoting Scott Wood (2016-07-21 04:31:48) > > > > > > On Wed, 2016-07-20 at 13:24 +0200, Arnd Bergmann wrote: > > > > > > > > On Saturday, July 16, 2016 9:50:21 PM CEST Scott Wood wrote: > > > > > > > > > > > > > > > From: yangbo lu <yangbo.lu@xxxxxxx> > > > > > > > > > > Move mpc85xx.h to include/linux/fsl and rename it to svr.h as a > > > > > common header file. This SVR numberspace is used on some ARM > > > > > chips as well as PPC, and even to check for a PPC SVR multi-arch > > > > > drivers would otherwise need to ifdef the header inclusion and > > > > > all references to the SVR symbols. > > > > > > > > > > Signed-off-by: Yangbo Lu <yangbo.lu@xxxxxxx> > > > > > Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx> > > > > > Acked-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> > > > > > Acked-by: Joerg Roedel <jroedel@xxxxxxx> > > > > > [scottwood: update description] > > > > > Signed-off-by: Scott Wood <oss@xxxxxxxxxxxx> > > > > > > > > > As discussed before, please don't introduce yet another vendor > > > > specific way to match a SoC ID from a device driver. > > > > > > > > I've posted a patch for an extension to the soc_device > > > > infrastructure to allow comparing the running SoC to a table of > > > > devices, use that instead. > > > As I asked before, in which relevant maintainership capacity are you > > > NACKing this? > > I'll nack the powerpc part until you guys can agree. > > OK, I've pulled these patches out. > > For the MMC issue I suggest using ifdef CONFIG_PPC and mfspr(SPRN_SVR) > like the clock driver does[1] and we can revisit the issue if/when we > need to do something similar on an ARM chip. [Lu Yangbo-B47093] I remembered that Uffe had opposed us to introduce non-generic header files(like '#include <asm/mpc85xx.h>') in mmc driver initially. So I think it will not be accepted to use ifdef CONFIG_PPC and mfspr(SPRN_SVR)... And this method still couldn’t get SVR of ARM chip now. Any other suggestion here? Thank you very much. - Yangbo Lu > > -Scott > > [1] One of the issues with Arnd's approach is that it wouldn't have > worked for early things like the clock driver, and he didn't seem to mind > using ifdef and > mfspr() there. ��.n��������+%������w��{.n�����{��i��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
