Re: [PATCH RFC 2/5] mmc: sdhci: Split sdhci_add_host()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/06/16 14:23, Adrian Hunter wrote:
> Split sdhci-add_host() in order to further our objective to make
> sdhci into a library.

s/sdhci-add_host/sdhci_add_host

> The split divides code that sets up mmc and sdhci parameters, from
> code that actually activates things - such as tasklet initialization,
> requesting the irq, and adding (and starting) the host.
> 
> This gives drivers an opportunity to change various settings before
> committing to start the host.
> 
> Drivers can continue to call sdhci_add_host() but drivers that want
> to take advantage of the split instead call sdhci_setup_host() followed
> by __sdhci_add_host().

If sdhci_setup_host() is successful, but then the subsequent call to
__sdhci_add_host() fails, then what should be called to clean-up? Does
not look like we can still call sdhci_remove_host() in this case.

Cheers
Jon

-- 
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux