On 10 June 2016 at 15:22, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > Apparently a cut-and-paste error, 'do_data_tag' is using 'brq' for data > size even though 'brq' has not been set up. Instead use blk_rq_sectors(). > > Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> Thanks, applied for next! Kind regards Uffe > --- > > > Hi > > I don't know if anyone is actually using packed writes, but this is > something I noticed. > > Regards > Adrian > > > drivers/mmc/card/block.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c > index b954516739be..aa5cfaf1fdf0 100644 > --- a/drivers/mmc/card/block.c > +++ b/drivers/mmc/card/block.c > @@ -1834,8 +1834,7 @@ static void mmc_blk_packed_hdr_wrq_prep(struct mmc_queue_req *mqrq, > do_data_tag = (card->ext_csd.data_tag_unit_size) && > (prq->cmd_flags & REQ_META) && > (rq_data_dir(prq) == WRITE) && > - ((brq->data.blocks * brq->data.blksz) >= > - card->ext_csd.data_tag_unit_size); > + blk_rq_bytes(prq) >= card->ext_csd.data_tag_unit_size; > /* Argument of CMD23 */ > packed_cmd_hdr[(i * 2)] = > (do_rel_wr ? MMC_CMD23_ARG_REL_WR : 0) | > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
