On 16/06/16 19:32, Ben Dooks wrote: > Fix the missing declarations of dml_start_xfer() and > dml_hw_init() by including mmci_qcom_dml.h to fix the > following warnings: > > drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static? > drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol 'dml_hw_init' was not declared. Should it be static? > > Since the module build doesn't export symbols, also > export the symbols from the mmci_qcom_dml.c file as > otherwise the module link process won't work. > > Note, since this is a very small addition to the mmci > module, it would better to build it into the main mmci > driver (either by direct copy, or multiple linked > module) I've also noted the driver doesn't have any MODULE_LICENSE or MODULE_AUTHOR fields in it. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html