> -----Original Message----- > From: Adrian Hunter [mailto:adrian.hunter@xxxxxxxxx] > Sent: Friday, June 10, 2016 5:07 PM > To: Venu Byravarasu; Ulf Hansson > Cc: linux-mmc; Alex Lemberg; Mateusz Nowak; Yuliy Izrailov; Jaehoon Chung; > Dong Aisheng; Das Asutosh; Zhangfei Gao; Dorfman Konstantin; David > Griego; Sahitya Tummala; Harjani Ritesh > Subject: Re: [PATCH RFC V2 33/46] mmc: mmc_test: Disable Command > Queue while mmc_test is used > > On 10/06/16 13:59, Venu Byravarasu wrote: > >> -----Original Message----- > >> From: linux-mmc-owner@xxxxxxxxxxxxxxx [mailto:linux-mmc- > >> owner@xxxxxxxxxxxxxxx] On Behalf Of Adrian Hunter > >> Sent: Friday, June 10, 2016 4:15 PM > >> To: Ulf Hansson > >> Cc: linux-mmc; Alex Lemberg; Mateusz Nowak; Yuliy Izrailov; Jaehoon > >> Chung; Dong Aisheng; Das Asutosh; Zhangfei Gao; Sujit Reddy Thumma; > >> Dorfman Konstantin; David Griego; Sahitya Tummala; Harjani Ritesh > >> Subject: [PATCH RFC V2 33/46] mmc: mmc_test: Disable Command Queue > >> while mmc_test is used > >> > >> Normal read and write commands may not be used while the command > >> queue is enabled. > > > > CQ may not be efficient when single rd/wr commands get issued with > variable delays in between. > > In such situations, CQ preparation for individual rd/wr cmds would be an > unnecessary overhead. > > Hence even when CQ is supported, prefer CQ only when more than 1 data > cmds are to be issued to device. > > So you are suggesting toggling CQ on/off depending on whether there is > more than 1 data request? I didn't go thro' your implementation part for CQ yet & my comment was generic. If preparation of CQ is taking N more operations than non-CQ command, then by not opting for CQ, you might save those N operations. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
