On Tue, May 31, 2016 at 12:39:58PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Tue, May 24, 2016 at 4:43 AM, Simon Horman
> <horms+renesas@xxxxxxxxxxxx> wrote:
> > --- a/drivers/mmc/host/sh_mobile_sdhi.c
> > +++ b/drivers/mmc/host/sh_mobile_sdhi.c
>
> > @@ -403,6 +580,30 @@ static int sh_mobile_sdhi_probe(struct platform_device *pdev)
> > if (ret < 0)
> > goto efree;
> >
> > + if (host->mmc->caps & MMC_CAP_UHS_SDR104)
> > + host->mmc->caps |= MMC_CAP_HW_RESET;
> > +
> > + if (of_id && of_id->data) {
> > + const struct sh_mobile_sdhi_of_data *of_data = of_id->data;
> > + const struct sh_mobile_sdhi_scc *taps = of_data->taps;
> > + bool hit = false;
> > +
> > + for (i = 0; i < of_data->taps_num; i++) {
> > + if (taps[i].clk_rate == 0 ||
> > + taps[i].clk_rate == host->mmc->f_max) {
> > + host->scc_tappos = taps->tap;
> > + hit = true;
> > + break;
> > + }
> > + }
> > +
> > + if (!hit)
> > + dev_warn(&host->pdev->dev, "Unknown clock rate for SDR104 and HS200\n");
>
> This warning triggers on sh7a0/kzm9g, r8a73a4/ape6evm, and
> r8a7740/armadillo.
>
> Perhaps the tap code should check if MMC_CAP_UHS_SDR104 is
> enabled?
Thanks. Yes, I think that would be sensible.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
