Re: [PATCH v2] mmc: core: Remove redundant rescan_disable flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29 April 2016 at 20:40, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
> On 28/04/2016 9:29 p.m., Ulf Hansson wrote:
>>
>> For the reasons explained below, it's safe to remove the rescan_disable
>> flag.
>>
>> 1)
>> cancel_delayed_work_sync() prevents an executing work from re-scheduling
>> itself.
>>
>> 2)
>> We are using the system_freezable_wq for the rescan works. As that queue
>> becomes frozen when userspace becomes frozen during system PM, we don't
>> need to disable the rescan works in the PM_SUSPEND_PREPARE phase.
>
>
> What about the case when a SDIO card has to be removed?  Seems like a rescan
> could theoretically get scheduled and run before the workqueue is frozen.

When the queue gets frozen, it means currently running works will be
synced. Works that are scheduled (or becomes scheduled) will be put on
hold and not allowed to run before the workqueue becomes un-frozen.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux