These are prevous submits: v1: http://www.spinics.net/lists/linux-mmc/msg35861.html v2: http://www.spinics.net/lists/linux-mmc/msg35869.html Both patches tried to check for NULL and ERR_PTR, which makes the check verbose, or loses the error code in ERR_PTR. This patch tries to make hard dependency on pinctrl. The driver itself does not require pinctrl to work. The pinctrl_pm_select_* calls in runtime suspend/resume can be dummies. The code section that needs pinctrl functions, is used to give users a heads up, that requred pinctrl states are missing. These are needed for the swakeup workaround. But technically the pm layer selects them. So pinctrl is needed for user feedback and only on those chips requiring the SWAKEUP workaround. Most chips don't require that workaround, forcing pinctrl for those might/might not be invasive. Select pinctrl in the drivers Kconfig section only selects only the core layer, which does nothing without an actual driver. Depending on pinctrl will break keystone, that doesn't have pinctrl selected. I chose 'select pinctrl' in Kconfig, since keystone and others will not notice the change. v3: - use select pinctrl in Kconf v2: - addressed issues from review - race-condition issue discussed in patch description Andreas Fenkart (1): mmc: omap_hsmmc: devm_pinctrl_get returns ERR_PTR upon error drivers/mmc/host/Kconfig | 1 + drivers/mmc/host/omap_hsmmc.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.8.0.rc3 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
