[...] >>>>> >>>>> -static void sdhci_activate_led(struct sdhci_host *host) >>>>> +static void __sdhci_led_activate(struct sdhci_host *host) >>>> >>>> The renaming here seems a bit unnecessary, but more importantly why >>>> can't you move these functions within the "if def sdhci leds" instead? >>> >>> They get used either way. Either we use the LEDS subsystem (and mmc core >>> controls them) or we turn them on/off directly from sdhci_request() etc. >> >> That seems wrong. Moreover it changes the current behaviour. > > How does it change the current behaviour? It was meant to be exactly the > same. Perhaps looking closely at whether the original code was 'ifdef' or > 'ifndef' will help. Huh. Yes, indeed you are right! Sorry for noise, again. > >> >> I am not sure why you want to use the leds in case of when the LED >> subsystem isn't available? > > I am attempting to preserve the existing behaviour, so that is just how it was. > I have applied all five patches for next! Thanks! Still, perhaps a future clean-up can adopt to my proposal above!? Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
