On 1 April 2016 at 18:41, Gwendal Grignou <gwendal@xxxxxxxxxx> wrote: > > > On Fri, Apr 1, 2016 at 3:06 AM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: >> >> >> I don't want to restore the callbacks. >> >> Instead, let's be a bit more clever and try to extend mmc_reset() to >> cover the MMC case as well. I haven't thought about that in detail, >> but I think it should work. > > I am posting a different path soon. > Also, given power_restore is gone, mmc_host_power_restore is going to crash > when called for a MMC or SD device. > Shall we remove the interface mmc_power_save_host/mmc_power_restore_host? It's in my long term plan, yes. > It is only supported for sdio devices, and used only by the wl1271 to power > cycle the controller via sysfs. I am wondering if we could use the > suspend/resume entry point instead. Regarding SDIO power management support in the mmc core, it's fragile/broken. I have gotten error reports several times, unfortunate it's not a trivial task to fix them but needs some structural changes in the mmc core for SDIO. I have plans to look into this, but I can't make any promises when that will be. In your case I would start by extending mmc_reset() to serve MMC cards as well, that seems like a fairly simple change. Then we can discuss SDIO separately, if you are still interested. :-) Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
