On 17 March 2016 at 12:29, Jon Hunter <jonathanh@xxxxxxxxxx> wrote: > > On 29/02/16 20:56, Lucas Stach wrote: >> The new code to do the clock rate setting externally to the SDMMC >> module has a shortcut to not propagate changes with a 0 rate to >> the CAR by simply bailing out. This breaks proper cutting of the >> card clock. Fix it by directly calling the correct sdhci function. >> >> Fixes: a8e326a911d3 "mmc: tegra: implement module external clock change" >> Signed-off-by: Lucas Stach <dev@xxxxxxxxxx> >> --- >> drivers/mmc/host/sdhci-tegra.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c >> index 212d51f..46a6bd1 100644 >> --- a/drivers/mmc/host/sdhci-tegra.c >> +++ b/drivers/mmc/host/sdhci-tegra.c >> @@ -194,7 +194,7 @@ static void tegra_sdhci_set_clock(struct sdhci_host *host, unsigned int clock) >> unsigned long host_clk; >> >> if (!clock) >> - return; >> + return sdhci_set_clock(host, clock);; > > Looks like the above adds an unnecessary additional semi-colon. > > Ulf, are you able to correct, or do you want a patch? Thanks for spotting this, I have amended the commit. No patch needed. Thanks! Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
