On 4 March 2016 at 10:41, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> On 3 March 2016 at 16:28, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>> On 16 February 2016 at 05:06, Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
>>> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
>>>
>>> This patch adds comments to describe the various ways card detection
>>> may be implemented and when polling is needed. Also a fix is included
>>> to prevent the MMC SPI driver from polling when a CD GPIO that supports
>>> interrupts is specified using the gpios DT property (case 1).
>>>
>>> Without this patch the DT node below results in the following output:
>>>
>>> spi_gpio: spi-gpio { /* SD2 @ CN12 */
>>> compatible = "spi-gpio";
>>> #address-cells = <1>;
>>> #size-cells = <0>;
>>> gpio-sck = <&gpio6 16 GPIO_ACTIVE_HIGH>;
>>> gpio-mosi = <&gpio6 17 GPIO_ACTIVE_HIGH>;
>>> gpio-miso = <&gpio6 18 GPIO_ACTIVE_HIGH>;
>>> num-chipselects = <1>;
>>> cs-gpios = <&gpio6 21 GPIO_ACTIVE_LOW>;
>>> status = "okay";
>>>
>>> spi@0 {
>>> compatible = "mmc-spi-slot";
>>> reg = <0>;
>>> voltage-ranges = <3200 3400>;
>>> spi-max-frequency = <25000000>;
>>> gpios = <&gpio6 22 GPIO_ACTIVE_LOW>; /* CD */
>>> };
>>> };
>>>
>>> # dmesg | grep mmc
>>> mmc_spi spi32766.0: SD/MMC host mmc0, no WP, no poweroff, cd polling
>>> mmc0: host does not support reading read-only switch, assuming write-enable
>>> mmc0: new SDHC card on SPI
>>> mmcblk0: mmc0:0000 SU04G 3.69 GiB
>>> mmcblk0: p1
>>>
>>> With this patch applied the "cd polling" portion above disappears.
>>>
>>> Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
>>
>> This looks good to me. Although do you think we need this for @stable as well?
>
> Ehh, as I am soon will be travelling and wanted this to be tested in
> linux next, I took the liberty to remove the comments, updated the
> change log and applied a stable tag.
>
> If think the comments are useful, please send a separate patch on top.
>
> So applied for fixes! Please have a look to make sure I looks okay to you.
Unfortunate I failed to send this in a PR to Linus within the 4.5 rc
cycle, apologize for the inconvenience!
Instead I have this queued for 4.6 and I have added a stable tag to it.
[...]
Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
