Re: [PATCH v3] mmc-utils: Merge the lsmmc tool into mmc-utils

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

On 23 February 2016 at 12:18, Chris Ball <chris@xxxxxxxxxx> wrote:
> Hi Baolin,
>
> What is the difference between v2 and v3?  It's good to include a
> changelog with each new patch.

Oh, sorry. I would add a changelog in next version. This version I
changed the ext_csd read command replacing with the parser in lsmmc.c.
It is not sensible if we combine the different extcsd parse style
together.

>
> Regarding the merge, I don't think it makes sense to merge in lsmmc.c
> if the entire EXT_CSD parser inside it can't be used right now.
> We might as well just leave it out altogether until it's ready to
> be used.  I don't think there's any point in adding a lot of new
> unused code just because we might want to use it later.
>
> Does that make sense?  Thanks,

OK. I'll remove the EXT_CSD parser from lsmmc.c code. Thanks for your comments.

>
> - Chris.
> --
> Chris Ball   <http://printf.net/>



-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux